fix(module-federation): do not rely on virtualRuntimeEntry #31831 #32387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit 468ff1e
☁️ Nx Cloud last updated this comment at |
leosvelperez
approved these changes
Aug 18, 2025
Coly010
requested review from
a team,
AgentEnder,
FrozenPandaz and
jaysoo
as code owners
Coly010
force-pushed
the
remove-virtual-runtime-usage
branch
from
caddeae to
933b4bd
Compare
Coly010
force-pushed
the
remove-virtual-runtime-usage
branch
from
933b4bd to
d52d581
Compare
Coly010
force-pushed
the
remove-virtual-runtime-usage
branch
from
d52d581 to
b78ed68
Compare
Coly010
force-pushed
the
remove-virtual-runtime-usage
branch
from
b0a27b2 to
7ad3170
Compare
Coly010
force-pushed
the
remove-virtual-runtime-usage
branch
from
7ad3170 to
7cc02ac
Compare
Coly010
force-pushed
the
remove-virtual-runtime-usage
branch
from
7cc02ac to
0d91630
Compare
Coly010
force-pushed
the
remove-virtual-runtime-usage
branch
from
0d91630 to
bbadfc3
Compare
Coly010
force-pushed
the
remove-virtual-runtime-usage
branch
from
1483235 to
9b654fb
Compare
Coly010
force-pushed
the
remove-virtual-runtime-usage
branch
from
9b654fb to
f82a2f6
Compare
Coly010
force-pushed
the
remove-virtual-runtime-usage
branch
from
f82a2f6 to
0180f30
Compare
4 tasks
jaysoo
approved these changes
Aug 21, 2025
Coly010
force-pushed
the
remove-virtual-runtime-usage
branch
from
0180f30 to
468ff1e
Compare
FrozenPandaz
approved these changes
Aug 21, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Aug 22, 2025
…2387) Previously, we needed to rely on `virtualRuntimeEntry` to allow builds between caching to operate successfully. In more recent version of `@module-federation/enhanced` this is no longer the case. By setting this option, it is now inflating the size of the bundles produced by Webpack and Rspack As it is no longer a strict requirement, remove it. Users can still set it manually if they run into issues Fixes #31831 Fixes #32404 (cherry picked from commit b8f9a95)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Previously, we needed to rely on
virtualRuntimeEntryto allow builds between caching to operate successfully.Expected Behavior
In more recent version of
@module-federation/enhancedthis is no longer the case.By setting this option, it is now inflating the size of the bundles produced by Webpack and Rspack
As it is no longer a strict requirement, remove it.
Users can still set it manually if they run into issues
Related Issue(s)
Fixes #31831
Fixes #32404