feat(rspack)!: remove deprecated deleteOutputPath and sassImplementation options - #32756
Merged
Merged
Conversation
…rs (#32716) The deprecated simpleName option has been removed from the library generators for Angular, React, Nest, and JS packages. Use the --name option to provide the exact name for the library. BREAKING CHANGE: simpleName option is no longer supported in library generators Closes NXC-3107, NXC-3098, NXC-3093, NXC-3111
Coly010
requested review from
AgentEnder,
FrozenPandaz and
jaysoo
as code owners
September 17, 2025 10:39
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
View your CI Pipeline Execution ↗ for commit a242bab
☁️ Nx Cloud last updated this comment at |
Coly010
force-pushed
the
nxc-3112-remove-deprecated-rspack-options
branch
from
September 17, 2025 10:48
4e5163e to
2250301
Compare
…r v22 (#32754) The default TypeScript plugin for Rollup has changed from rollup-plugin-typescript2 to @rollup/plugin-typescript. To continue using the legacy plugin, explicitly set useLegacyTypescriptPlugin: true in your configuration. Resolves NXC-3094 --------- Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com>
jaysoo
reviewed
Sep 19, 2025
jaysoo
approved these changes
Sep 19, 2025
Coly010
force-pushed
the
nxc-3112-remove-deprecated-rspack-options
branch
from
September 19, 2025 14:53
2250301 to
b860e3e
Compare
…tTestingPreset` (#32787) This PR removes an unnecessary logic for React component testing via Cypress. We've made it not possible to have optional webpack configs a while back (i.e. non-isolated config support). This means that even legacy users _must_ have a webpack config using `composePlugin(...)`. Thus, pass the options to that plugin function and things will continue to work as usual for those users.
Coly010
force-pushed
the
nxc-3112-remove-deprecated-rspack-options
branch
from
September 23, 2025 09:46
b860e3e to
33efa88
Compare
Coly010
requested review from
a team,
MaxKless,
lourw,
meeroslav and
vsavkin
as code owners
September 23, 2025 09:46
Coly010
force-pushed
the
nxc-3112-remove-deprecated-rspack-options
branch
from
September 23, 2025 10:05
1f918ba to
f15657f
Compare
Coly010
force-pushed
the
nxc-3112-remove-deprecated-rspack-options
branch
from
September 23, 2025 10:21
f15657f to
a242bab
Compare
Coly010
removed request for
a team,
JamesHenry,
MaxKless,
StalkAltan,
bcabanes,
lourw,
meeroslav,
nartc,
nixallover,
philipjfulcher,
rarmatei and
vsavkin
September 23, 2025 10:22
![graphite-app[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
FrozenPandaz
force-pushed
the
next-major
branch
from
September 23, 2025 19:13
2a50463 to
c0971f1
Compare
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
The rspack package contains deprecated options that were marked with TODO(v22) comments for
removal:
These deprecated options were still being referenced in the codebase and schema files,
potentially causing confusion for users.
Expected Behavior
Remove the deprecated options from the rspack package to clean up the API for v22:
Related Issue(s)
Resolves NXC-3112