feat(webpack)!: remove deprecated deleteOutputPath and sassImplementation options - #32828
Merged
Conversation
…rs (#32716) The deprecated simpleName option has been removed from the library generators for Angular, React, Nest, and JS packages. Use the --name option to provide the exact name for the library. BREAKING CHANGE: simpleName option is no longer supported in library generators Closes NXC-3107, NXC-3098, NXC-3093, NXC-3111
…r v22 (#32754) The default TypeScript plugin for Rollup has changed from rollup-plugin-typescript2 to @rollup/plugin-typescript. To continue using the legacy plugin, explicitly set useLegacyTypescriptPlugin: true in your configuration. Resolves NXC-3094 --------- Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com>
…tTestingPreset` (#32787) This PR removes an unnecessary logic for React component testing via Cypress. We've made it not possible to have optional webpack configs a while back (i.e. non-isolated config support). This means that even legacy users _must_ have a webpack config using `composePlugin(...)`. Thus, pass the options to that plugin function and things will continue to work as usual for those users.
Contributor
|
View your CI Pipeline Execution ↗ for commit 5e0db2a
☁️ Nx Cloud last updated this comment at |
Coly010
approved these changes
Sep 23, 2025
![nx-cloud[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…tion options The webpack package contains deprecated options that were marked with TODO(v22) comments for removal: - deleteOutputPath option (Line 87 in nx-app-webpack-plugin-options.ts) - sassImplementation option (Line 224 in nx-app-webpack-plugin-options.ts) These deprecated options were still being referenced in the codebase and schema files, potentially causing confusion for users. Remove the deprecated options from the webpack package to clean up the API for v22: - Remove deleteOutputPath option from the webpack executor and related configurations (use Webpack's output.clean option instead) - Remove sassImplementation option from the webpack executor and related configurations (sass-embedded is now the default) - Add a migration to automatically update existing workspaces that use these deprecated options Fixes NXC-3108
![graphite-app[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
FrozenPandaz
force-pushed
the
next-major
branch
from
September 23, 2025 19:13
2a50463 to
c0971f1
Compare
jaysoo
force-pushed
the
NXC-3108
branch
2 times, most recently
from
September 23, 2025 20:43
c0042b2 to
c6d34a6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
There was a problem hiding this comment.
Nx Cloud is proposing a fix for your failed CI:
We've updated the test snapshot to reflect the migration from the deprecated deleteOutputPath option to Webpack's native output.clean option. This change aligns the test expectations with the new behavior introduced by removing the deprecated webpack options.
We verified this fix by re-running e2e-webpack:e2e-ci--src/webpack.legacy.test.ts.
diff --git a/e2e/webpack/src/__snapshots__/webpack.legacy.test.ts.snap b/e2e/webpack/src/__snapshots__/webpack.legacy.test.ts.snap
index 3c4ba6e26b..65a30d646b 100644
--- a/e2e/webpack/src/__snapshots__/webpack.legacy.test.ts.snap
+++ b/e2e/webpack/src/__snapshots__/webpack.legacy.test.ts.snap
@@ -114,7 +114,7 @@ exports[`Webpack Plugin (legacy) ConvertConfigToWebpackPlugin, should convert wi
module.exports = composePlugins((config) => {
// Update the webpack config as needed here.
// e.g. \`config.plugins.push(new MyPlugin())\`
- config.output.cache = true;
+ config.output.clean = true;
return config;
});
"
⚙️ An Nx Cloud workspace admin can disable these reviews in workspace settings.
FrozenPandaz
pushed a commit
that referenced
this pull request
Sep 29, 2025
…tion options (#32828) The webpack package contains deprecated options that were marked with TODO(v22) comments for removal: - deleteOutputPath option - sassImplementation option These deprecated options were still being referenced in the codebase and schema files, potentially causing confusion for users. Remove the deprecated options from the webpack package to clean up the API for v22: - Remove deleteOutputPath option from the webpack executor and related configurations (use Webpack's output.clean option instead) - Remove sassImplementation option from the webpack executor and related configurations (sass-embedded is now the default) - Add a migration to automatically update existing workspaces that use these deprecated options Closes NXC-3108 --------- Co-authored-by: Colum Ferry <cferry09@gmail.com> Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com>
FrozenPandaz
pushed a commit
that referenced
this pull request
Sep 29, 2025
…tion options (#32828) The webpack package contains deprecated options that were marked with TODO(v22) comments for removal: - deleteOutputPath option - sassImplementation option These deprecated options were still being referenced in the codebase and schema files, potentially causing confusion for users. Remove the deprecated options from the webpack package to clean up the API for v22: - Remove deleteOutputPath option from the webpack executor and related configurations (use Webpack's output.clean option instead) - Remove sassImplementation option from the webpack executor and related configurations (sass-embedded is now the default) - Add a migration to automatically update existing workspaces that use these deprecated options Closes NXC-3108 --------- Co-authored-by: Colum Ferry <cferry09@gmail.com> Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com>
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The webpack package contains deprecated options that were marked with TODO(v22) comments for removal:
These deprecated options were still being referenced in the codebase and schema files, potentially causing confusion for users.
Remove the deprecated options from the webpack package to clean up the API for v22:
Closes NXC-3108