fix(module-federation): ensure angular rspack module federation supports live reload - #33137
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 635bfc0
☁️ Nx Cloud last updated this comment at |
![graphite-app[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Coly010
force-pushed
the
angular-rspack/bubble-errors
branch
from
October 20, 2025 12:07
840f839 to
635bfc0
Compare
leosvelperez
approved these changes
Oct 20, 2025
jaysoo
approved these changes
Oct 20, 2025
This was referenced Oct 20, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Oct 21, 2025
…rts live reload (#33137) ## Current Behavior Angular Rspack outputs to CJS for Module Federation. It also has potential issues to cause infinite live reload loops. ## Expected Behavior Angular Rspack with Module Federation should work as expected This PR also adds: - example of Module Federation with Angular Rspack in `examples/angular-rspack/module-federation` (cherry picked from commit 23aabf7)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Angular Rspack outputs to CJS for Module Federation. It also has potential issues to cause infinite live reload loops.
Expected Behavior
Angular Rspack with Module Federation should work as expected
This PR also adds:
examples/angular-rspack/module-federation