fix(release)!: better respect version plan file contents for changelog entries - #33166
Conversation
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
View your CI Pipeline Execution ↗ for commit 23ee90d
☁️ Nx Cloud last updated this comment at |
| } | ||
|
|
||
| if (this.isVersionPlans) { | ||
| this.conventionalCommitsConfig = { |
There was a problem hiding this comment.
I am honestly not sure why this was hardcoded to defaults, it means custom config isn't respected even when present. It definitely makes sense to get rid of this, the defaults will have been set in config.ts in the case the user is not customizing
| changelogEntryVersion: releaseVersion.rawVersion, | ||
| project: null, | ||
| isVersionPlans: false, | ||
| isVersionPlans: !!nxReleaseConfig.versionPlans, |
There was a problem hiding this comment.
Again I don't have a good explanation for why this was previously hardcoded to false... it should respect the config
![nx-cloud[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
d6ae24a to
a05daa7
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
JamesHenry
changed the title
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
3 participants
Current Behavior
The rendered changelog is not faithful enough to the original version plan markdown contents.
Expected Behavior
The version plan author maintains maximum control over final changelog contents.
Related Issue(s)
Fixes #