Skip to content

fix(core): correctly identify local workspace dependencies on windows - #33408

Merged
JamesHenry merged 1 commit into
masterfrom
windows-local-package-json-dependencies
Nov 7, 2025
Merged

fix(core): correctly identify local workspace dependencies on windows#33408
JamesHenry merged 1 commit into
masterfrom
windows-local-package-json-dependencies

Conversation

@JamesHenry

Copy link
Copy Markdown
Contributor

Current Behavior

When local dependency resolution was improved in #32784 there was a regression introduced for Windows because of path matching behaviour.

Expected Behavior

Windows matches other OSes and benefits from the improved resolution.

Related Issue(s)

Fixes #

@JamesHenry
JamesHenry requested a review from a team as a code owner November 7, 2025 10:27
@JamesHenry
JamesHenry requested a review from Cammisuli November 7, 2025 10:27
@vercel

vercel Bot commented Nov 7, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nx-dev Ready Ready Preview Nov 7, 2025 10:30am
@netlify

netlify Bot commented Nov 7, 2025

Copy link
Copy Markdown

Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit e936cb2
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/690dc981a97d2d0008276e2e
😎 Deploy Preview https://deploy-preview-33408--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud

nx-cloud Bot commented Nov 7, 2025

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit e936cb2

Command Status Duration Result
nx affected --targets=lint,test,test-kt,build,e... ✅ Succeeded 33m 20s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 2m 14s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 10s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-07 11:06:12 UTC

@JamesHenry
JamesHenry merged commit a694866 into master Nov 7, 2025
20 checks passed
@JamesHenry
JamesHenry deleted the windows-local-package-json-dependencies branch November 7, 2025 11:08
FrozenPandaz pushed a commit that referenced this pull request Nov 10, 2025
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants