Conversation
Using .mts extension forces files to always be treated as ESM modules, ensuring consistent behavior regardless of package.json or tsconfig settings. This matters for Node 24 because by default Node will strip types from `.ts` files and then they are resolved through normal Node resolution. In the past we can control CJS/ESM through tsconfig options, but now only extension or `type` in `package.json` matters. Changes: - Updated all createOrEditViteConfig calls to pass useEsmExtension: true - Updated normalizeViteConfigFilePathWithTree to check for .mts files first - Updated test files to expect .mts config files - Updated snapshots to reflect new .mts extension Closes NXC-3446
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 24e82e5
☁️ Nx Cloud last updated this comment at |
jaysoo
force-pushed
the
NXC-3446
branch
3 times, most recently
from
November 18, 2025 13:40
95e0862 to
297a419
Compare
…r does not like .mts
Coly010
approved these changes
Nov 19, 2025
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using .mts extension forces files to always be treated as ESM modules, ensuring consistent behavior regardless of package.json or tsconfig settings.
This matters for Node 24 because by default Node will strip types from
.tsfiles and then they are resolved through normal Node resolution. In the past we can control CJS/ESM through tsconfig options, but now only extension ortypeinpackage.jsonmatters.Changes:
Closes NXC-3446