feat(core): add page up/down to tui shortcuts - #34525
Merged
AgentEnder merged 4 commits intoApr 17, 2026
Merged
Conversation
✅ Deploy Preview for nx-docs canceled.
|
✅ Deploy Preview for nx-dev canceled.
|
yharaskrik
force-pushed
the
jay/add-page-up-down-to-nx-tui
branch
from
February 20, 2026 06:10
d99ca86 to
cdae067
Compare
leosvelperez
left a comment
leosvelperez
left a comment
Member
There was a problem hiding this comment.
Thanks! This was something on my list, but I hadn't gotten to it.
Left some suggestions to avoid the loops and update the scroll state more directly.
| // Handle PageUp/PageDown for full-page scrolling when not in interactive mode | ||
| KeyCode::PageUp if !self.is_interactive => { | ||
| let (rows, _) = pty_mut.get_dimensions(); | ||
| let page = (rows as u8).saturating_sub(2).max(1); |
Member
There was a problem hiding this comment.
rows is u16 (from get_dimensions()) but as u8 silently keeps only the low 8 bits. For terminals >255 rows (very unlikely, but not impossible), this would wrap unpredictably (e.g., 256 rows → page=1, 300 → page=42).
Suggested change
| let page = (rows as u8).saturating_sub(2).max(1); | |
| let page = (rows.min(255) as u8).saturating_sub(2).max(1); |
| } | ||
| KeyCode::PageDown if !self.is_interactive => { | ||
| let (rows, _) = pty_mut.get_dimensions(); | ||
| let page = (rows as u8).saturating_sub(2).max(1); |
Member
There was a problem hiding this comment.
Same here:
Suggested change
| let page = (rows as u8).saturating_sub(2).max(1); | |
| let page = (rows.min(255) as u8).saturating_sub(2).max(1); |
Comment on lines
+171
to
+174
| let page = viewport_height.saturating_sub(2).max(1); | ||
| for _ in 0..page { | ||
| self.scroll_up(); | ||
| } |
Member
There was a problem hiding this comment.
The loop calls scroll_up() N times, each doing a bounds check + decrement. Could be a single operation:
Suggested change
| let page = viewport_height.saturating_sub(2).max(1); | |
| for _ in 0..page { | |
| self.scroll_up(); | |
| } | |
| let page = viewport_height.saturating_sub(2).max(1); | |
| self.scroll_offset = self.scroll_offset.saturating_sub(page); |
Comment on lines
+180
to
+183
| let page = viewport_height.saturating_sub(2).max(1); | ||
| for _ in 0..page { | ||
| self.scroll_down(viewport_height); | ||
| } |
Member
There was a problem hiding this comment.
Same thing here:
Suggested change
| let page = viewport_height.saturating_sub(2).max(1); | |
| for _ in 0..page { | |
| self.scroll_down(viewport_height); | |
| } | |
| let page = viewport_height.saturating_sub(2).max(1); | |
| self.scroll_offset = (self.scroll_offset + page).min(max_scroll); |
Comment on lines
+83
to
+86
| let page = self.viewport_height.saturating_sub(2).max(1); | ||
| for _ in 0..page { | ||
| self.scroll_up(); | ||
| } |
Member
There was a problem hiding this comment.
Same loop pattern — can be a single offset operation (scrollbar state only needs one update):
Suggested change
| let page = self.viewport_height.saturating_sub(2).max(1); | |
| for _ in 0..page { | |
| self.scroll_up(); | |
| } | |
| let page = self.viewport_height.saturating_sub(2).max(1); | |
| self.scroll_offset = self.scroll_offset.saturating_sub(page); | |
| self.scrollbar_state = self | |
| .scrollbar_state | |
| .content_length(self.content_height) | |
| .viewport_content_length(self.viewport_height) | |
| .position(self.scroll_offset); |
Comment on lines
+90
to
+93
| let page = self.viewport_height.saturating_sub(2).max(1); | ||
| for _ in 0..page { | ||
| self.scroll_down(); | ||
| } |
Member
There was a problem hiding this comment.
Same here:
Suggested change
| let page = self.viewport_height.saturating_sub(2).max(1); | |
| for _ in 0..page { | |
| self.scroll_down(); | |
| } | |
| let page = self.viewport_height.saturating_sub(2).max(1); | |
| let max_scroll = self.content_height.saturating_sub(self.viewport_height); | |
| self.scroll_offset = (self.scroll_offset + page).min(max_scroll); | |
| self.scrollbar_state = self | |
| .scrollbar_state | |
| .content_length(self.content_height) | |
| .viewport_content_length(self.viewport_height) | |
| .position(self.scroll_offset); |
leosvelperez
previously requested changes
Feb 25, 2026
Contributor
|
View your CI Pipeline Execution ↗ for commit 6bf262a
☁️ Nx Cloud last updated this comment at |
AgentEnder
force-pushed
the
jay/add-page-up-down-to-nx-tui
branch
from
April 16, 2026 21:59
56b16be to
6bf262a
Compare
AgentEnder
approved these changes
Apr 17, 2026
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Page Up/Down are not implemented as navigation keys in TUI
Expected Behavior
They are now Implemented.
Related Issue(s)
Fixes #