Skip to content

fix(module-federation): bump @module-federation/enhanced to ^2.3.3 - #35314

Merged
jaysoo merged 1 commit into
masterfrom
issue-35311
Apr 20, 2026
Merged

fix(module-federation): bump @module-federation/enhanced to ^2.3.3#35314
jaysoo merged 1 commit into
masterfrom
issue-35311

Conversation

@jaysoo

@jaysoo jaysoo commented Apr 16, 2026

Copy link
Copy Markdown
Member

This PR updates our @module-federation/enhanced range from ^2.1.0 to ^2.3.3 since 2.3.1 has a dependency on a compromised axios version. This does not block existing workspaces from updating themselves, but ensures npm install in an existing workspace will force an update of the enhanced package.

Fixes ##35311

@jaysoo
jaysoo requested a review from a team as a code owner April 16, 2026 15:06
@jaysoo
jaysoo requested a review from lourw April 16, 2026 15:06
@netlify

netlify Bot commented Apr 16, 2026

Copy link
Copy Markdown

Deploy Preview for nx-dev ready!

Name Link
🔨 Latest commit 1aea9a9
🔍 Latest deploy log https://app.netlify.com/projects/nx-dev/deploys/69e64bfa6c4c370009113c45
😎 Deploy Preview https://deploy-preview-35314--nx-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Apr 16, 2026

Copy link
Copy Markdown

Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit 1aea9a9
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/69e64bfc09460500086a013e
😎 Deploy Preview https://deploy-preview-35314--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud

nx-cloud Bot commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 1aea9a9

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 41m 53s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 3s View ↗
nx-cloud record -- pnpm nx-cloud conformance:check ✅ Succeeded 18s View ↗
nx build workspace-plugin ✅ Succeeded 1m 49s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 23s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 14s View ↗

☁️ Nx Cloud last updated this comment at 2026-04-20 16:41:46 UTC

@jaysoo
jaysoo force-pushed the issue-35311 branch 2 times, most recently from 1f8b3a2 to 46d6fe5 Compare April 17, 2026 16:09

@nx-cloud nx-cloud Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ The fix from Nx Cloud was applied

We updated the newProject() call in ts-solution-mf.test.ts to pre-install @nx/rspack, @nx/cypress, and @nx/jest alongside @nx/react. This fixes the failure where the @nx/react:host generator registers these packages as Nx plugins in nx.json and immediately tries to load them, but they weren't available in the temp workspace, causing Nx to throw "Unable to resolve local plugin" errors for all three packages.

Tip

We verified this fix by re-running e2e-react:e2e-ci--src/module-federation/ts-solution-mf.test.ts.

Suggested Fix changes
diff --git a/e2e/react/src/module-federation/ts-solution-mf.test.ts b/e2e/react/src/module-federation/ts-solution-mf.test.ts
index 5b780fe1d5..b151fae516 100644
--- a/e2e/react/src/module-federation/ts-solution-mf.test.ts
+++ b/e2e/react/src/module-federation/ts-solution-mf.test.ts
@@ -33,7 +33,10 @@ function runCLI(cmd: string, opts?: { env?: Record<string, string> }) {
 
 describe('React Rspack Module Federation - TS Solution + PM Workspaces', () => {
   beforeAll(() => {
-    newProject({ packages: ['@nx/react'], preset: 'ts' });
+    newProject({
+      packages: ['@nx/react', '@nx/rspack', '@nx/cypress', '@nx/jest'],
+      preset: 'ts',
+    });
   });
 
   afterAll(() => cleanupProject());

🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.

Revert fix via Nx Cloud  

View interactive diff ↗

➡️ This fix was applied by Jack Hsu

🎓 Learn more about Self-Healing CI on nx.dev

@jaysoo
jaysoo merged commit 7812501 into master Apr 20, 2026
24 checks passed
@jaysoo
jaysoo deleted the issue-35311 branch April 20, 2026 17:07
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants