fix(module-federation): bump @module-federation/enhanced to ^2.3.3 - #35314
Conversation
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit 1aea9a9
☁️ Nx Cloud last updated this comment at |
1f8b3a2 to
46d6fe5
Compare
There was a problem hiding this comment.
✅ The fix from Nx Cloud was applied
We updated the newProject() call in ts-solution-mf.test.ts to pre-install @nx/rspack, @nx/cypress, and @nx/jest alongside @nx/react. This fixes the failure where the @nx/react:host generator registers these packages as Nx plugins in nx.json and immediately tries to load them, but they weren't available in the temp workspace, causing Nx to throw "Unable to resolve local plugin" errors for all three packages.
Tip
✅ We verified this fix by re-running e2e-react:e2e-ci--src/module-federation/ts-solution-mf.test.ts.
Suggested Fix changes
diff --git a/e2e/react/src/module-federation/ts-solution-mf.test.ts b/e2e/react/src/module-federation/ts-solution-mf.test.ts
index 5b780fe1d5..b151fae516 100644
--- a/e2e/react/src/module-federation/ts-solution-mf.test.ts
+++ b/e2e/react/src/module-federation/ts-solution-mf.test.ts
@@ -33,7 +33,10 @@ function runCLI(cmd: string, opts?: { env?: Record<string, string> }) {
describe('React Rspack Module Federation - TS Solution + PM Workspaces', () => {
beforeAll(() => {
- newProject({ packages: ['@nx/react'], preset: 'ts' });
+ newProject({
+ packages: ['@nx/react', '@nx/rspack', '@nx/cypress', '@nx/jest'],
+ preset: 'ts',
+ });
});
afterAll(() => cleanupProject());
🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.
View interactive diff ↗➡️ This fix was applied by Jack Hsu
🎓 Learn more about Self-Healing CI on nx.dev
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This PR updates our
@module-federation/enhancedrange from^2.1.0to^2.3.3since2.3.1has a dependency on a compromised axios version. This does not block existing workspaces from updating themselves, but ensuresnpm installin an existing workspace will force an update of the enhanced package.Fixes ##35311