Skip to content

[Robustness] handle an overridden type #2356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ljharb wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Robustness] handle an overridden type #2356

ljharb wants to merge 1 commit into from

Conversation

@ljharb
Copy link
Member

@ljharb ljharb commented Nov 21, 2020

Fixes #2352
@sladyn98
Copy link
Contributor

sladyn98 commented Mar 1, 2021

Looks like the tests are failing on this one.
@ljharb ljharb mentioned this pull request Mar 1, 2021
Open
@sladyn98
Copy link
Contributor

sladyn98 commented Mar 16, 2021

@ljharb Let me know if you need help to push this one over the line
sladyn98
sladyn98 reviewed Mar 18, 2021
View reviewed changes
@ljharb ljharb force-pushed the type_override branch 3 times, most recently from 5f62dab to c8d70e0 Compare March 18, 2021 16:26
@ljharb
Copy link
Member Author

ljharb commented Mar 18, 2021

@sladyn98 still failing; happy to get some help on this one :-)
@sladyn98
Copy link
Contributor

sladyn98 commented Mar 18, 2021

Yeah now all of the zsh tests are unhappy :(
@ljharb
Copy link
Member Author

ljharb commented Mar 18, 2021

i think maybe the reason i didn't have command type in nvm_has before was because it doesn't work in zsh :-/
tejusp

This comment was marked as spam.

Sign in to view

@ljharb ljharb force-pushed the master branch 2 times, most recently from c6cfc3a to c20db2a Compare June 10, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@ljharb @sladyn98 @tejusp