Skip to content

Fix issue 1388 #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
voodoos wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix issue 1388 #1419

voodoos wants to merge 4 commits into from

Conversation

@voodoos
Copy link
Collaborator

@voodoos voodoos commented Dec 21, 2021

Fixes issue #1388.

This necessitate an update of dot-merlin-reader.
I did not test with dune ocaml-merlin.

@vzaliva could you try this branch and confirm whether it solves your issue ? Thank you !
@voodoos voodoos requested a review from let-def December 21, 2021 13:55
@voodoos voodoos linked an issue Dec 21, 2021 that may be closed by this pull request
'+' in include path with dune #1388
Open
@vzaliva
Copy link

vzaliva commented Dec 22, 2021

I've tested and it does not work. In merlin-log buffer:

"include_dirs": [],

The corresponding flags stanza:

(flags (:standard -w -27 -I +../cerberus/frontend))

It compiles fine with dune.
@voodoos
Copy link
Collaborator Author

voodoos commented Jan 5, 2022

Are you sure your editor plugin uses the Merlin from this branch ?

One way to do that is to use an opam pin:
opam pin merlin git@github.com:voodoos/merlin.git#fix-issue-1388
@vzaliva
Copy link

vzaliva commented Jan 5, 2022

yes, this is how I tested.
@voodoos
Copy link
Collaborator Author

voodoos commented Jan 6, 2022

Ok. Unfortunately I am not able to reproduce a similar issue on my test project any more.
Could you provide a small project and a few reproduction steps ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@voodoos @vzaliva