Locate constructors' exact positions #1537
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
reviewed
Dec 1, 2022
| -> Longident.t | ||
| -> Env.t | ||
| -> (Path.t * Shape.Sig_component_kind.t * Shape.Uid.t * Location.t) option | ||
| -> (Path.t * Shape.Sig_component_kind.t * Shape.Uid.t * Location.t * bool) option |
Member
There was a problem hiding this comment.
Would it be possible to switch bool to a more descriptive type? For example some (polymorphic?) variant describing the two options?
voodoos
force-pushed
the
locate-constructor-exact-pos
branch
from
a1ffdc0 to
2dcfaa6
Compare
Collaborator
Author
|
After discussing this issue with @pitag-ha we realized that it only answers the problem for type's declarations, not definitions. I am turning this into a draft while looking for a more robust answer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Merlin will locate the type of a constructor, not the constructor itself.
This is much improved in that PR.