Skip to content

fix: make /search mode-aware #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
zats wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: make /search mode-aware #36

zats wants to merge 1 commit into from

Conversation

@zats
Copy link

@zats zats commented Jan 26, 2026 •
edited
Loading

Summary

  • make /search mode-aware with a default redirect
  • point header Search link to /search

Rationale

  • Standardizing on /search gives us stable, shareable URLs across deployments. It lets us map search to the right mode today while keeping a single bookmarkable entry point that we can rewire later without breaking links.

Heads-up

  • Quick check: do our SSR deploy envs always set the intended mode (e.g., via VITE_SITE_MODE)? If not, /search could resolve to the wrong mode when VITE_SOULHUB_SITE_URL is set. src/routes/search.tsx:9-31

Testing

  • bun run lint (pass)
  • bun run test (fail: src/lib/site.test.ts; src/tests/search-route.test.ts; src/tests/upload.route.test.tsx)
  • bun run test:e2e (fail: 3 tests in e2e/clawdhub.e2e.test.ts)
  • bun run coverage (fail: same as bun run test)
  • bun run test:pw (fail: preview server couldn’t start; build required)
@zats
fix: make /search mode-aware
34583a6 
Notes:\n- Medium: /search now depends on getSiteMode() during beforeLoad. On server-side routing, if VITE_SITE_MODE isn’t set and VITE_SOULHUB_SITE_URL is set (as in .env.local), getSiteMode() will resolve to souls and redirect /search to / even on the ClawdHub deployment. This is a regression risk vs the old always-/skills redirect. Confirm deployment envs guarantee correct mode. src/routes/search.tsx:9-31
@vercel
Copy link
Contributor

vercel bot commented Jan 26, 2026

@zats is attempting to deploy a commit to the Amantus Machina Team on Vercel.

A member of the Team first needs to authorize it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@zats