Skip to content

[OP-19204] User Timeline view for Resource Management#24026

Open
klaustopher wants to merge 18 commits into
devfrom
feature-OP-19204-user-timeline
Open

[OP-19204] User Timeline view for Resource Management#24026
klaustopher wants to merge 18 commits into
devfrom
feature-OP-19204-user-timeline

Conversation

@klaustopher

Copy link
Copy Markdown
Contributor

Ticket

https://community.openproject.org/projects/OP/work_packages/OP-19204/activity

What are you trying to accomplish?

  • Extract some stuff to generalize from the WP timeline view
  • Build a user timeline view

Screenshots

What approach did you choose and why?

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)
@github-actions

Copy link
Copy Markdown

Caution

The provided work package version does not match the core version

Details:

Please make sure that:

  • The work package version OR your pull request target branch is correct
@klaustopher klaustopher force-pushed the feature-OP-19204-user-timeline branch from 57ff9a6 to e192ef0 Compare June 30, 2026 14:27
Comment thread app/models/persisted_view.rb Outdated
@oliverguenther

Copy link
Copy Markdown
Member

Not sure if new or not, but there is quite some flickering when switching between views:

2026-07-01_12-52-10

@oliverguenther oliverguenther left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a first pass and the majority of the changes look straightforward. I'd hope we can find another way other than bloating the base view. The user timeline view behaves as specified.

On the specific changes to unify the previous resource view, I'd appreciate a separate pair of eyes by @dfriquet

@klaustopher klaustopher force-pushed the feature-OP-19204-user-timeline branch from 948d24c to bd213b4 Compare July 1, 2026 12:16
@klaustopher

Copy link
Copy Markdown
Contributor Author

The flickering issue will be addressed in #24028

@klaustopher klaustopher force-pushed the feature-OP-19204-user-timeline branch from bd213b4 to ce4f60a Compare July 1, 2026 12:45
@klaustopher klaustopher force-pushed the feature-OP-19204-user-timeline branch from ce4f60a to 0f148ca Compare July 1, 2026 15:03
@klaustopher klaustopher changed the title Feature op 19204 user timeline Jul 1, 2026
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./modules/team_planner/spec/features/query_handling_spec.rb[1:3:1:1]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #24026, linked for reference only):

- `rspec ./modules/team_planner/spec/features/query_handling_spec.rb[1:3:1:1]`

Treat this as a standalone task, unrelated to PR #24026. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #24026 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @klaustopher to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @klaustopher, and request a review from @klaustopher.
On every commit, set @klaustopher as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants