Skip to content

Release 1.3 #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jun 6, 2024
Merged

Release 1.3 #96

merged 18 commits into from
Jun 6, 2024

Conversation

markxnelson
Copy link
Member

No description provided.

Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
@markxnelson markxnelson self-assigned this Jun 6, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 6, 2024
@markxnelson markxnelson marked this pull request as draft June 6, 2024 18:05
container_name: exporter
ports:
- 9161:9161
environment:
- DB_USERNAME=system
- DB_USERNAME=sys
- DB_PASSWORD=Welcome12345
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DO we want an actual password here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it has to have one to start it up :)

Copy link
Member

@andytael andytael Jun 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but maybe say <YOUR_PASSWORD_HERE>

Copy link
Member

@andytael andytael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things

Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
@markxnelson markxnelson marked this pull request as ready for review June 6, 2024 18:10
Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
andytael
andytael previously approved these changes Jun 6, 2024
Copy link
Member

@andytael andytael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
andytael
andytael previously approved these changes Jun 6, 2024
Copy link
Member

@andytael andytael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
andytael
andytael previously approved these changes Jun 6, 2024
Copy link
Member

@andytael andytael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
andytael
andytael previously approved these changes Jun 6, 2024
Copy link
Member

@andytael andytael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markxnelson markxnelson requested a review from aberinnj June 6, 2024 18:54
Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
@markxnelson markxnelson merged commit e7c8c3c into main Jun 6, 2024
2 checks passed
@markxnelson markxnelson deleted the mark/1.3 branch June 6, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
3 participants