Resolving a conversation in a review comment deletes draft reply

[qubist]

Hi there!

Just an unexpected behavior report.

Steps to reproduce:

1. I open a PR
2. Someone reviews and comments on a line of code
3. I type in a reply but I don’t click “Comment” yet
   • 

     Screen Shot 2021-04-02 at 12.23.28 PM971×724 50.4 KB
4. I click “Resolve conversation” below the reply box
5. The conversation is resolved and minimized
   • https: [slash slash] i.imgur [dot] com/2DwgNl8.png
6. I open it back up and my comment is gone
   • https://i.imgur.com/4iaiHAX.png

Expected behavior

Either I can open up the conversation and my draft reply is still there, or the conversation isn’t minimized when I resolve it but still have text in the “Leave a comment” box. Or maybe I’m not allowed to resolve a conversation while having text in the box? Not sure. But the current behavior caused me to lose work a few times now when writing a comment that also resolves the conversation.

Details

• I was logged in
• This happened on an old repo I was using to test (Create LICENSE by qubist · Pull Request #1 · qubist/aqo · GitHub) as well as other repos.
• I don’t think there’s documentation for this.

PS: limitations on number of embedded screenshots and links in a post makes in really hard to post detailed bug reports with pictures

[ernest-phillips]

Hello @qubist and welcome to the Community!

I agree, that this flow’s intention is not super obvious. May be even a little buggy. I am not sure of the best way to remedy this, but I will bring this up to our design team to get the conversation started.

Thanks for your detailed notes here.

[fapapa]

+1 on a fix for this. Personally I’ve been “commenting” and hitting the “resolve conversation” button thinking it was also submitting the comment. Since it minimizes the conversation, I was thinking that my co-workers were getting these comments, but instead they were just seeing me close conversation without doing anything to actually resolve them. Making me look like a jerk.

Disabling the resolve button (or warning me when pressing it) when there’s a draft comment would resolve what is a very bad user experience for me.

[bhasden]

I just ran into this issue as well. It’d be great to have some sort of warning even just keeping the draft comment around when clicking “Resolve Conversation”.

[tfonda-fbk]

I too would really like to see this fixed. I've just lost an extensive reply I had written under a Discussion answer just because I clicked the "Mark as answer" button before submitting the reply. It really is poor UX.