Skip to content

fix/issue 1080#1457

Draft
kristof-mattei wants to merge 8 commits intoorhun:mainfrom
kristof-mattei:fix/issue_1080
Draft

fix/issue 1080#1457
kristof-mattei wants to merge 8 commits intoorhun:mainfrom
kristof-mattei:fix/issue_1080

Conversation

@kristof-mattei
Copy link
Copy Markdown

  • fix: fixing bug identified in Issue #1080
  • chore: re-running fmt with nightly
  • chore: re-re-running fmt with nightly
  • chore: switching out unwrap() with expect() per linter
  • chore: swapping to plain array per linter
  • chore: adding additional scenarios in to cover missing code lines
  • fix: address PR comments
@kristof-mattei kristof-mattei requested a review from orhun as a code owner April 1, 2026 19:11
@kristof-mattei kristof-mattei marked this pull request as draft April 1, 2026 19:11
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.77%. Comparing base (0a69719) to head (af5ccca).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1457      +/-   ##
==========================================
+ Coverage   47.45%   47.77%   +0.32%     
==========================================
  Files          24       24              
  Lines        2131     2144      +13     
==========================================
+ Hits         1011     1024      +13     
  Misses       1120     1120              
Flag Coverage Δ
unit-tests 47.77% <100.00%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants