feat: increase entropy of OTPs generated by code strategy #4241
+530
−160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving forward, OTPs generated by the code strategy will match pattern `[0-9a-zA-Z]{8}` instead of `[0-9]{6}`. This increases entropy and makes it easier to defend against reverse brute force attacks.
See ory-corp/cloud#3724
Member
Author
|
A test is needed to ensure the legacy code generation still works. |
Contributor
|
Can we follow up on this to close: https://github.com/ory-corp/cloud/issues/3724? |
Member
Author
|
Yes, just need to figure out how to change it without breaking customers' existing implementations - especially custom UIs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving forward, OTPs generated by the code strategy will match pattern
[0-9a-zA-Z]{8}instead of[0-9]{6}. This increases entropy and makes it easier to defend against reverse brute force attacks.See https://github.com/ory-corp/cloud/issues/3724
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments