Skip to content

Clean-up DateUtils.mm - #43

Open
printercu wants to merge 2 commits into
overtake:masterfrom
printercu:patch-2
Open

Clean-up DateUtils.mm#43
printercu wants to merge 2 commits into
overtake:masterfrom
printercu:patch-2

Conversation

@printercu

Copy link
Copy Markdown
  • Remove duplicated if-branches.
  • Use stringForShortTime to format time in all methods.
  • Extract stringForDateLong method.

I have not changed any logic except removing if (timeinfo.tm_year != timeinfo_now.tm_year). This makes dates be formatted in consistent way on the first first week of year.

Indeed I want to add time to message timestamps as described in #32. But found that commit with some improvements got too large.

overtake and others added 2 commits November 7, 2017 18:39
Make PIP show on all desktop/fullscreen apps
- Remove duplicated if-branches.
- Use stringForShortTime to format time in all methods.
- Extract stringForDateLong method.
@CLAassistant

CLAassistant commented Nov 26, 2017

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ printercu
❌ overtake
You have signed the CLA already but the status is still pending? Let us recheck it.

@overtake
overtake force-pushed the master branch 3 times, most recently from 9aa8690 to 579cebb Compare September 22, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants