Skip to content

fix: remove unused condition from msc_status_engine.c #3412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: v2/master
Choose a base branch
from
Open

fix: remove unused condition from msc_status_engine.c #3412

wants to merge 1 commit into from

Conversation

airween
Copy link
Member

@airween airween commented Jul 2, 2025

what

This PR removes an unused condition from msc_status_engin.c if the target is DARWIN.

why

In one of a previous commit we removed some unused variables, but it seems like it's still in use.

Unfortunately this was not revealed because that part is only used if the target is DARWIN.

references

Thanks @Greentears.
@airween airween mentioned this pull request Jul 2, 2025
Closed
@airween airween added the 2.x Related to ModSecurity version 2.x label Jul 2, 2025
@airween airween requested a review from fzipi July 2, 2025 20:17
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 2, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud
@airween airween requested a review from theseion July 2, 2025 20:18
@theseion
Copy link
Collaborator

theseion commented Jul 3, 2025

This is the commit where variable was removed.
@airween
Copy link
Member Author

airween commented Jul 3, 2025

This is the commit where variable was removed.

I think I wrote the same in my initial commit:

In one of a previous commit we removed some unused variables, but it seems like it's still in use.

😃

Btw thanks for the reviewing!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to ModSecurity version 2.x
2 participants
@airween @theseion