-
-
Notifications
You must be signed in to change notification settings - Fork 145
fix(DataFrame): #799 to_dict #1283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
94f0d80
to
d041ff2
Compare
1b5bb8c
to
7da086e
Compare
8bf75d2
to
4f1fb49
Compare
4f1fb49
to
afb5729
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @cmp0xff
Hi @Dr-Irv, thank you for the approval. However, regarding #1283 (comment), do we have some guideline here? |
Not really. My attitude is that if we construct a set of tests that are allowing us to test proper usage, and reject improper usage, I'm fine with using Maybe one day the typing gods will agree on an approach to do "negative" typing. |
assert_type()
to assert the type of any return value