Skip to content

Conversation

@sbarnat
Copy link

@sbarnat sbarnat commented Jan 17, 2026

Upgraded to the latest versions of the https://github.com/googleapis/googleapis and https://github.com/bazelbuild/remote-apis
RE v2.1+

@sbarnat
Copy link
Author

sbarnat commented Jan 20, 2026

AI Disclosure: Changes were made by an AI agent and review by multiple humans. Unfortunately, none of them are Rust experts, so some special attention is warranted there.

@benjyw
Copy link
Contributor

benjyw commented Jan 20, 2026

Before reviewing, why are there generated .pb.go files here?

@sbarnat
Copy link
Author

sbarnat commented Jan 20, 2026

Before reviewing, why are there generated .pb.go files here?

These were copied "as-is" from the remote-apis repo, eg. https://github.com/bazelbuild/remote-apis/blob/main/build/bazel/remote/asset/v1/remote_asset.pb.go

Anything else that should not be not copied from these repos?

@tdyas
Copy link
Contributor

tdyas commented Jan 21, 2026

Before reviewing, why are there generated .pb.go files here?

These were copied "as-is" from the remote-apis repo, eg. https://github.com/bazelbuild/remote-apis/blob/main/build/bazel/remote/asset/v1/remote_asset.pb.go

Anything else that should not be not copied from these repos?

The .pb.go files are irrelevant to Pants. Only the proto files matter since the prost crate will generate Rust bindings at build time.

@benjyw
Copy link
Contributor

benjyw commented Jan 21, 2026

I mean this respectfully and constructively, but I'm not confident about the quality of this PR, given that thousands of lines of unnecessary generated code were included in it, either due to AI or to cargo-culting. It would be helpful if this underwent a deeper pre-review audit by the author and others on their team, and if you could provide a more detailed explanation in a comment on the PR of how it was generated, and how the logic was subsequently humanly validated.

@cburroughs
Copy link
Contributor

Thanks for the contribution. We've just branched for 2.31.x, so merging this pull request now will come out in 2.32.x, please move the release notes updates to docs/notes/2.32.x.md if that's appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants