external tool upgrade: support constraints on added versions #23043
+227
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cburroughs
added
the
category:internal
I often find myself wanting to do do something other than upgrading to the absolute latest. For example, I might want to add the latest in a patch series in hold back from a major semver change. This adds a --version-constraint argument to help assist with those situations. The default behavior is unchanged. Notable limitations: * Using packaging here, so not every idiosyncratic tool versioning scheme is necessarily understood. * There isn't a fast way to get an index of "all" the GitHub releases, so there are heuristics and a flag around how many to consider.
cburroughs
force-pushed
the
csb/external-tool-ver-bounds
branch
from
c211b01 to
f18c90d
Compare
benjyw
approved these changes
Jan 31, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I often find myself wanting to do do something other than upgrading to the absolute latest. For example, I might want to add the latest in a patch series in hold back from a major semver change. This adds a --version-constraint argument to help assist with those situations.
The default behavior is unchanged.
Notable limitations: