external tool upgrade: support helm #23044
Open
+85
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helm artifacts are hosted on get.helm.sh. This is currently Azure Blob storage but has historically been other things (ex: Google Cloud). I think "Helm source code is on GitHub" is a more stable assumption than whatever object store and/or CDN they want to use, so I took the approach of querying the GitHub releases (reusing the existing code) rather than trying to scrape get.helm.sh or assume Azure APIs would be available.
cburroughs
added
the
category:internal
benjyw
approved these changes
Jan 31, 2026
Member
|
Interesting, Helm doesn't also put releases on GH Releases... |
sureshjoshi
approved these changes
Jan 31, 2026
sureshjoshi
approved these changes
Jan 31, 2026
Member
|
Also interesting that I can repeatedly approve a PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helm artifacts are hosted on get.helm.sh. This is currently Azure Blob storage but has historically been other things (ex: Google Cloud). I think "Helm source code is on GitHub" is a more stable assumption than whatever object store and/or CDN they want to use, so I took the approach of querying the GitHub releases (reusing the existing code) rather than trying to scrape get.helm.sh or assume Azure APIs would be available.