Remove support for Get #23062
Remove support for Get #23062
Conversation
benjyw
added
the
release-notes:not-required
| class PyGeneratorResponseCall: | ||
| rule_id: str | ||
| output_type: type | ||
| input_types: Sequence[type] |
There was a problem hiding this comment.
We no longer access this field on the python side, and in fact only access .inputs in MockCall test infrastructure, so could probably get rid of that too.
| call_node, | ||
| "Expected an `**implicitly(..)` application as the only keyword input.", | ||
| ) | ||
| explanation = self._format( |
There was a problem hiding this comment.
This was the only remaining use of GetParseError, so I inlined it here and used a regular ValueError, for simplicity.
| } else if let Ok(get_multi) = response.cast::<PySequence>() { | ||
| // Was an `All` or `concurrently`. | ||
| let gogs = get_multi | ||
| let generators = get_multi |
There was a problem hiding this comment.
gog was GetOrGenerator, but now it's always a generator.
| fn interpret_implicit_args( | ||
| py: Python, | ||
| input_arg0: Option<Bound<'_, PyAny>>, | ||
| input_arg1: Option<Bound<'_, PyAny>>, |
There was a problem hiding this comment.
The two args were for the input type and instance of that input type, in the case of Get(OutputType, InputType, instance), but this is no longer a thing.
| } | ||
|
|
||
| #[derive(Debug)] | ||
| pub struct Get { |
There was a problem hiding this comment.
This is the heart of it...
| /// might use either the call-by-name or `Get` syntax. | ||
| All(Vec<GetOrGenerator>), | ||
| /// immediately produce a `Call`, and then return its value), or async "rule helpers". | ||
| All(Vec<Value>), |
There was a problem hiding this comment.
We no longer need GetOrGenerator and can use the generator Value directly.
3 participants
Delete the bulk of the code needed to
support
Get(andEffect).Follow up changes will further trim code
that is no longer needed, but this
is already a big enough step for now.