Extract JavaScript backend test resources to files #23066
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate test_integration_test.py to use external test resource files instead of inlined rule_runner.write_files() calls. This follows the pattern established in the TypeScript backend and makes lockfiles easier to maintain with actual package manager commands. Changes: - Add test_resources/ directory with jest_project and mocha_project - Add testutil.py with load_js_test_project() helper - Refactor tests to load base projects and override specific files - Remove unused fixtures (_find_lockfile_resource, jest_lockfile, etc.) Ref: pantsbuild#22807 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
added 2 commits
February 1, 2026 20:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate test_integration_test.py to use external test resource files instead of inlined rule_runner.write_files() calls. This follows the pattern established in the TypeScript backend and makes lockfiles easier to maintain with actual package manager commands.
Changes:
Ref: #22807