Always init descriptors ht as non-packed #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nielsdos I think I nailed the solution. Can you please approve this PR? |
nielsdos
approved these changes
Jun 3, 2025
There was a problem hiding this comment.
So the missing piece of the puzzle is that the bottom slots of the packed array were never reused and then the conversion happens once the "load factor" heuristic triggers. Then we still have some unused slots because of how the conversion works and we are left with unused memory.
The idea makes sense.
mvorisek
added a commit
that referenced
this pull request
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4
Simillar to many of
zend_hash_real_init_mixed()usage in php-src.Credit goes to @nielsdos as he identified the problem is in https://github.com/php/pecl-database-oci8/blob/v3.4/oci8_lob.c#L106.