Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: php/php-src
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 53f76f3
Choose a base ref
...
head repository: php/php-src
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 89eb11d
Choose a head ref
  • 17 commits
  • 2 files changed
  • 2 contributors

Commits on May 26, 2025

  1. Fix date test

    @nielsdos
    nielsdos committed May 26, 2025
    Configuration menu
    Copy the full SHA
    0a2f367 View commit details
    Browse the repository at this point in the history

  2. gen_stub: add maximum option to generateVersionDependentFlagCode() 

    In preparation for moving this logic to a dedicated class, add support for a
maximum version of PHP in the generation of version-dependent flags. This
replaces the manual logic in `FuncInfo::getFunctionEntry()` to split up the
flags that are used when PHP 8.4 is not supported.
    @DanielEScherzer
    DanielEScherzer committed May 26, 2025
    Configuration menu
    Copy the full SHA
    e0ef34c View commit details
    Browse the repository at this point in the history

  3. gen_stub: create VersionFlags class 

    This new class holds the logic for applying different flags based on the PHP
version, and replaces `VariableLike::addFlagForVersionsAbove()` (use
`VersionFlags::addForVersionsAbove()`) and `generateVersionDependentFlagCode()`
(use `VersionFlags::generateVersionDependentFlagCode()`).
    @DanielEScherzer
    DanielEScherzer committed May 26, 2025
    Configuration menu
    Copy the full SHA
    34f63aa View commit details
    Browse the repository at this point in the history

  4. gen_stub: move generateClassEntryCode() into FileInfo 

    Reduce the number of global functions by moving it to instance method
`FileInfo::generateClassEntryCode()`.
    @DanielEScherzer
    DanielEScherzer committed May 26, 2025
    Configuration menu
    Copy the full SHA
    f1d533d View commit details
    Browse the repository at this point in the history

  5. gen_stub: move getFileDocComments() into FileInfo 

    Reduce the number of global functions by moving it to static method
`FileInfo::getFileDocComments()`. Since it is only used by
`FileInfo::parseStubFile()`, also make it private.
    @DanielEScherzer
    DanielEScherzer committed May 26, 2025
    Configuration menu
    Copy the full SHA
    3ab42e6 View commit details
    Browse the repository at this point in the history

  6. gen_stub: simplify generateFunctionEntries()

    @DanielEScherzer
    DanielEScherzer committed May 26, 2025
    Configuration menu
    Copy the full SHA
    e2617a0 View commit details
    Browse the repository at this point in the history

  7. gen_stub: remove unused AbstractConstName::equals()

    @DanielEScherzer
    DanielEScherzer committed May 26, 2025
    Configuration menu
    Copy the full SHA
    e57d449 View commit details
    Browse the repository at this point in the history

  8. gen_stub: replace AbstractConstName::isClassConst() with instanceof

    @DanielEScherzer
    DanielEScherzer committed May 26, 2025
    Configuration menu
    Copy the full SHA
    848f8bb View commit details
    Browse the repository at this point in the history

  9. gen_stub: add SimpleType::toTypeInfo() 

    Simplifies the implementation of `::toTypeCode()` and `::toTypeMask()` by
combining the `switch` blocks.
    @DanielEScherzer
    DanielEScherzer committed May 26, 2025
    Configuration menu
    Copy the full SHA
    8a8118b View commit details
    Browse the repository at this point in the history

  10. gen_stub: simplify FuncInfo::getFunctionEntry()

    @DanielEScherzer
    DanielEScherzer committed May 26, 2025
    Configuration menu
    Copy the full SHA
    7ec8fc7 View commit details
    Browse the repository at this point in the history

  11. gen_stub: simplify FuncInfo::getFramelessDeclaration()

    @DanielEScherzer
    DanielEScherzer committed May 26, 2025
    Configuration menu
    Copy the full SHA
    67bfcae View commit details
    Browse the repository at this point in the history

  12. gen_stub: replace FunctionOrMethodName::isMethod() with instanceof

    @DanielEScherzer
    DanielEScherzer committed May 26, 2025
    Configuration menu
    Copy the full SHA
    d09d831 View commit details
    Browse the repository at this point in the history

  13. gen_stub: make some FuncInfo methods private 

    * `FuncInfo::isFinalMethod()`
* `FuncInfo::getModifierNames()`
* `FuncInfo::equalsApartFromNameAndRefcount()`
    @DanielEScherzer
    DanielEScherzer committed May 26, 2025
    Configuration menu
    Copy the full SHA
    5e597c3 View commit details
    Browse the repository at this point in the history

  14. gen_stub: inline computeStubHash()

    @DanielEScherzer
    DanielEScherzer committed May 26, 2025
    Configuration menu
    Copy the full SHA
    f51b78a View commit details
    Browse the repository at this point in the history

  15. gen_stub: avoid unneeded regex match

    @DanielEScherzer
    DanielEScherzer committed May 26, 2025
    Configuration menu
    Copy the full SHA
    5c786ba View commit details
    Browse the repository at this point in the history

  16. gen_stub: add ConstInfo::getPredefinedConstantElement() 

    Simplifies the implementation of `::getPredefinedConstantTerm()` and
`::getPredefinedConstantEntry()`, which only differ in the name of the tag
used.
    @DanielEScherzer
    DanielEScherzer committed May 26, 2025
    Configuration menu
    Copy the full SHA
    8aca966 View commit details
    Browse the repository at this point in the history

  17. gen_stub: simplify ClassInfo::getRegistration()

    @DanielEScherzer
    DanielEScherzer committed May 26, 2025
    Configuration menu
    Copy the full SHA
    89eb11d View commit details
    Browse the repository at this point in the history
Loading