Skip to content

pdo_odbc: Don't fetch 256 byte blocks for long columns #10809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+47 −25
Open

pdo_odbc: Don't fetch 256 byte blocks for long columns #10809

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
466e8ad
pdo_odbc: Don't fetch 256 byte blocks for long columns
NattyNarwhal Mar 8, 2023
c2ec656
change to separate by 256 bytes, when C->fetched_len == SQL_NO_TOTAL
SakiTakamachi Oct 20, 2023
d45858c
Make long column buffer size single define
NattyNarwhal Oct 25, 2023
5dc5975
Use ZendMM page size minus zend_string overhead
NattyNarwhal Jun 18, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use ZendMM page size minus zend_string overhead 
Change recommended by Christoph.

Probably a little better performance wise I have to guess.
  • Loading branch information
@NattyNarwhal
NattyNarwhal committed Jun 18, 2025
commit 5dc597513cf85984918ee9250731b22c95579e00
2 changes: 1 addition & 1 deletion ext/pdo_odbc/odbc_stmt.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
#include "php_pdo_odbc_int.h"

/* Buffer size; bigger columns than this become a "long column" */
#define LONG_COLUMN_BUFFER_SIZE 2048
#define LONG_COLUMN_BUFFER_SIZE (ZEND_MM_PAGE_SIZE- ZSTR_MAX_OVERHEAD)

enum pdo_odbc_conv_result {
PDO_ODBC_CONV_NOT_REQUIRED,
Expand Down