Skip to content

Fix ending tag of 'title' element #11079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix ending tag of 'title' element #11079

wants to merge 1 commit into from

Conversation

j-mattsson
Copy link

No description provided.

@nielsdos
Copy link
Member

I already fixed it here: #10706
Your patch doesn't work as-is because you also need to change the lengths.
Also, you're actually supposed to change the PHP file and use the build system to generate the phar stub C file. Unfortunately, this wasn't always done properly in the past so now we have 2 different stubs (one in the C file and one in the PHP file) which are out-of-sync, which is what my PR is trying to fix.

@medabkari
Copy link

@nielsdos Since your patch already fixed the ending title tag, I believe this PR should be closed.

I was reading through the PRs and came across this one!

@nielsdos nielsdos closed this May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants