Skip to content

[RFC] Implement final anonymous classes #11126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[RFC] Implement final anonymous classes #11126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions Zend/tests/final_anonymous_class_1.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
--TEST--
Final anonymous classes
--FILE--
<?php

$x = new final class {};

echo "OK";

?>
--EXPECTF--
OK
12 changes: 12 additions & 0 deletions Zend/tests/final_anonymous_class_2.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
--TEST--
Final anonymous classes
--FILE--
<?php

$x = new final class {};
class_alias($x::class, 'alias');
class aliasExtends extends alias {}

?>
--EXPECTF--
Fatal error: Class aliasExtends cannot extend final class class@anonymous in %s on line %d
10 changes: 10 additions & 0 deletions Zend/tests/final_anonymous_class_3.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
--TEST--
Final anonymous classes
--FILE--
<?php

$x = new final final class {};

?>
--EXPECTF--
Fatal error: Multiple final modifiers are not allowed in %s on line %d
10 changes: 0 additions & 10 deletions Zend/tests/gh10377_3.phpt
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions Zend/zend_compile.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -931,8 +931,8 @@ uint32_t zend_add_anonymous_class_modifier(uint32_t flags, uint32_t new_flag)
"Cannot use the abstract modifier on an anonymous class", 0);
return 0;
}
if (new_flag & ZEND_ACC_FINAL) {
zend_throw_exception(zend_ce_compile_error, "Cannot use the final modifier on an anonymous class", 0);
if ((flags & ZEND_ACC_FINAL) && (new_flag & ZEND_ACC_FINAL)) {
zend_throw_exception(zend_ce_compile_error, "Multiple final modifiers are not allowed", 0);
return 0;
}
if ((flags & ZEND_ACC_READONLY_CLASS) && (new_flag & ZEND_ACC_READONLY_CLASS)) {
Expand Down