ext/phar: Remove phar_resolve_alias() #15860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From a quick glance over the PHP extensions this file doesn't seem to be used outside of php-src, yes. So then probably could be removed from being installed. |
As this is unused and a SourceGraph search returns 0 result
Girgias
force-pushed
the
phar-remove-api
branch
from
17b9acc to
ffc99bd
Compare
petk
approved these changes
Sep 14, 2024
|
I will wait to merge this after the branch has been cut |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this is unused and a SourceGraph search returns 0 result.
I'm not sure if we can just delete the header in the future?