ext/phar: Refactor phar_call_openssl_signverify() #16750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsdos
requested changes
Nov 11, 2024
ext/phar/util.c
Outdated
| ZVAL_STRINGL(&openssl, is_sign ? "openssl_sign" : "openssl_verify", is_sign ? sizeof("openssl_sign")-1 : sizeof("openssl_verify")-1); | ||
| zend_function *fn = NULL; | ||
| if (is_sign) { | ||
| fn = zend_hash_str_find_ptr_lc(EG(function_table), ZEND_STRL("openssl_sign")); |
There was a problem hiding this comment.
You don't need the _lc variants in this if/else, because the input string is already lowercased.
There was a problem hiding this comment.
Also, by looking into EG(function_table) instead of CG(function_table), you're allowing global user functions to be called. The previous code already allowed that too though...
There was a problem hiding this comment.
I'm happy to change it to CG as that's probably "better".
Girgias
force-pushed
the
phar-openssl-fcc
branch
from
0ff81c4 to
89082b7
Compare
nielsdos
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The one concern I have is that I don't think this actually has a test and I'm not sure how to write one :|