RFC: Deprecate type juggling to and from bool for function type juggling context

[Girgias]

RFC: https://wiki.php.net/rfc/deprecate-function-bool-type-juggling

@nicolas-grekas this should allow you to check if SF is affected :)

[NattyNarwhal]

do you know why I get the following with the ODBC failures on CI

Not sure how the Windows tests are set up, but I think it's coming from here; it'd be returning false if they don't exist (similar to ext/pdo/test/pdo_test.inc):

php-src/ext/pdo_odbc/tests/common.phpt

Lines 26 to 38 in 642d729

	if (false !== getenv('PDOTEST_DSN')) {
	// user should have to set PDOTEST_DSN so that:
	// 1. test is skipped if user doesn't want to test it, even if they have MS Access installed
	// 2. it detects if ODBC driver is not installed - to avoid test bug
	// 3. it detects if ODBC driver is installed - so test will be run
	// 4. so a specific ODBC driver can be tested - if system has multiple ODBC drivers
	$config['ENV']['PDOTEST_DSN'] = getenv('PDOTEST_DSN');
	$config['ENV']['PDOTEST_USER'] = getenv('PDOTEST_USER');
	$config['ENV']['PDOTEST_PASS'] = getenv('PDOTEST_PASS');
	if (false !== getenv('PDOTEST_ATTR')) {
	$config['ENV']['PDOTEST_ATTR'] = getenv('PDOTEST_ATTR');
	}

That include seems to assume the other variables are set if this one is, which doesn't seem to be the case here:

php-src/.github/scripts/windows/test_task.bat

Line 50 in 642d729

set PDOTEST_DSN=odbc:%ODBC_TEST_DSN%

[Girgias]

do you know why I get the following with the ODBC failures on CI

Not sure how the Windows tests are set up, but I think it's coming from here; it'd be returning false if they don't exist (similar to ext/pdo/test/pdo_test.inc):

php-src/ext/pdo_odbc/tests/common.phpt

Lines 26 to 38 in 642d729

	if (false !== getenv('PDOTEST_DSN')) {
	// user should have to set PDOTEST_DSN so that:
	// 1. test is skipped if user doesn't want to test it, even if they have MS Access installed
	// 2. it detects if ODBC driver is not installed - to avoid test bug
	// 3. it detects if ODBC driver is installed - so test will be run
	// 4. so a specific ODBC driver can be tested - if system has multiple ODBC drivers
	$config['ENV']['PDOTEST_DSN'] = getenv('PDOTEST_DSN');
	$config['ENV']['PDOTEST_USER'] = getenv('PDOTEST_USER');
	$config['ENV']['PDOTEST_PASS'] = getenv('PDOTEST_PASS');
	if (false !== getenv('PDOTEST_ATTR')) {
	$config['ENV']['PDOTEST_ATTR'] = getenv('PDOTEST_ATTR');
	}

That include seems to assume the other variables are set if this one is, which doesn't seem to be the case here:

php-src/.github/scripts/windows/test_task.bat

Line 50 in 642d729

set PDOTEST_DSN=odbc:%ODBC_TEST_DSN%

Ah lovely, I love how many bugs this proposal is finding in our own test suite lol