Skip to content

avoid false failure for long path #18992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

remicollet
Copy link
Member

With very long path, socket path may be truncated before $socketFilePrefix,

In which case, test is failing with Socket files were not found message

This is a false failure, as the log contains the expected message:

[01-Jul-2025 05:38:07] WARNING: [pool fpm_pool] cannot bind to UNIX socket '/builddir/build/BUILD/php85-php-8.5.0_DEV.20250630-build/php-src-c9249e2d3aa401bda5d9a3071e86e0594807ed00/sapi/fpm/tests/socket-file-fpm-unix-socket-too-long-filename-but-starts-anyway-0000-0000-0000-0000-0000-0000-0000-0000-0000-0000-0000.sock' as path is too long (found length: 244, maximal length: 108), trying cut socket path instead '/builddir/build/BUILD/php85-php-8.5.0_DEV.20250630-build/php-src-c9249e2d3aa401bda5d9a3071e86e0594807ed00/s'

So only report about Socket file is the same as configured (failed test because path not truncated)

Also avoid the Warning: Undefined array key 0 in .../sapi/fpm/tests/socket-uds-too-long-filename-start.php on line 41

@remicollet remicollet requested a review from bukka as a code owner July 1, 2025 03:46
@remicollet
Copy link
Member Author

Ping @JoshuaBehrens who adds this test

@JoshuaBehrens
Copy link
Contributor

Hi @remicollet I had issues in a nixos devenv setup where the fpm socket file was in a path, that was nested deeply. I had no idea what was happening here when the socket file was not usable for communication with the webserver. So eventually it was more helpful to understand why my socket file configuration was not working. Reading up on the maximum length made sense but was not easy to find out. When you get an error message about it is much easier to spot and fix.

More on the story here #11066

Was this already helpful? :D Are you running the tests also in a directory where path is very nested? I can assume, that this might break a test setup.

@remicollet
Copy link
Member Author

Hi @remicollet I had issues in a nixos devenv setup where the fpm socket file was in a path, that was nested deeply.

This change makes sense
This PR is only about the new test, failing in very deep tree (see message above)

Copy link
Contributor

@JoshuaBehrens JoshuaBehrens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok I got it. Makes sense to me so far :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment