Fix GH-18990, bug #81029, bug #47314: SOAP HTTP socket not closing on object destruction #19001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on object destruction Currently the resource is attached to the object and its refcount is increased. This means that the refcount to the resource is 2 instead of 1 as expected. A refcount of 2 is necessary in the current code because of how the error handling works: by using convert_to_null() the resource actually goes to rc_dtor_func(), dropping its refcount to 1. So on error the refcount is correct. To solve the issue, let `stream` conceptually be a borrow of the resource with refcount 1, and just use ZVAL_NULL() to prevent calling rc_dtor_func() on the resource.
Girgias
approved these changes
Jul 1, 2025
| php_stream_auto_cleanup(stream); | ||
| ZVAL_RES(Z_CLIENT_HTTPSOCKET_P(this_ptr), stream->res); | ||
| GC_ADDREF(stream->res); | ||
| php_stream_to_zval(stream, Z_CLIENT_HTTPSOCKET_P(this_ptr)); |
There was a problem hiding this comment.
No need for the auto cleanup anymore ? (IDK what that function does)
There was a problem hiding this comment.
That macro will also do the same thing that auto cleanup does:
Lines 270 to 274 in 59dd0f8
Anyway, that "auto cleanup" name is a badly chosen name. It just means that the resource is exposed as a zval and will be cleaned up that way.
There was a problem hiding this comment.
Right... that is indeed a bad name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the resource is attached to the object and its refcount is increased. This means that the refcount to the resource is 2 instead of 1 as expected. A refcount of 2 is necessary in the current code because of how the error handling works: by using convert_to_null() the resource actually goes to rc_dtor_func(), dropping its refcount to 1. So on error the refcount is correct.
To solve the issue, let
streamconceptually be a borrow of the resource with refcount 1, and just use ZVAL_NULL() to prevent calling rc_dtor_func() on the resource.