Skip to content

Minor soap property handling cleanups #19014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Minor soap property handling cleanups #19014

wants to merge 2 commits into from
+45 −44

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented Jul 2, 2025

No description provided.

nielsdos added 2 commits July 2, 2025 22:20
@nielsdos
Don't deref soap private properties
9e1ad7a 
They are private and can't be made references.
@nielsdos
Use ZVAL_NULL() directly for Z_CLIENT_USE_PROXY_P()
b53f460 
This is just an IS_LONG property, no need to do anything fancy.
@nielsdos nielsdos requested a review from Girgias July 2, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Extension: soap
1 participant
@nielsdos