sapi: convert current_user field to zend_string* - #22902
Merged
Merged
Conversation
Prevents some reallocations and strlen() recomputations
Girgias
force-pushed
the
2026-07-sapi-globals-types
branch
from
July 28, 2026 07:55
8f111cd to
4af34c4
Compare
Girgias
marked this pull request as ready for review
July 28, 2026 08:22
Girgias
requested review from
bukka,
devnexen,
dstogov and
kocsismate
as code owners
July 28, 2026 08:22
devnexen
requested changes
Jul 29, 2026
| PHP_MD5Final(digest, &md5_context); | ||
| make_digest(md5str, digest); | ||
| key = emalloc(len+sizeof("/wsdl-")-1+user_len+2+sizeof(md5str)); | ||
| key = emalloc(len+sizeof("/wsdl-")-1+ZSTR_LEN(user)+2+sizeof(md5str)); |
Member
There was a problem hiding this comment.
key = emalloc(len+sizeof("/wsdl-")-1+ZSTR_LEN(user)+1+2+sizeof(md5str));
...
memcpy(key+len, ZSTR_VAL(user), ZSTR_LEN(user));
len += ZSTR_LEN(user);
Member
Author
There was a problem hiding this comment.
I wonder if maybe this shouldn't be converted to use a smart str as the logic seems quite brittle. But nicely spotted.
devnexen
approved these changes
Jul 29, 2026
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents some reallocations and strlen() recomputations