Skip to content

Run scandir overflow test on Windows only - #22934

Merged
arnaud-lb merged 1 commit into
php:masterfrom
NickSdot:perf/scandir-windows-only
Jul 30, 2026
Merged

Run scandir overflow test on Windows only#22934
arnaud-lb merged 1 commit into
php:masterfrom
NickSdot:perf/scandir-windows-only

Conversation

@NickSdot

@NickSdot NickSdot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Extracted from #22917.

Avoids creating 70,000 files on platforms unaffected by the Win32 DIR_W32.offset regression. Shaves ~9s off non-Windows test runs.

Ref: d3cc9e2#commitcomment-194333406
cc @arnaud-lb

@NickSdot
NickSdot requested a review from bukka as a code owner July 30, 2026 10:58
@arnaud-lb
arnaud-lb merged commit 955e2ea into php:master Jul 30, 2026
17 of 18 checks passed
@arnaud-lb

Copy link
Copy Markdown
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants