Optimize false === is_string($x)
in opcache
#4909
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimization acts on opcodes that are guaranteed to return booleans.
(It's based on the below case for ZEND_BOOL and ZEND_BOOL_NOT)
Code such as
return is_string($this->prop) === false;
will benefit from it whenopcache is enabled.
A contrived example of a worst-case scenario is below.
This PR uses bit operations,
so that this optimization will also work for
false !== is_string($x)
and any future combinations generated for ZEND_TYPE_CHECK.
Similar to GH-4906 (can be merged independently)
EDIT: Fixed, that should have been a logical xor, not a binary xor