Fix #81543: parse_url omits leading slash in windows paths #7598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! IMO it's okay for master, if we properly document the change. |
Pchelolo
force-pushed
the
parse_url_windows_paths
branch
from
c2d2075 to
a18157a
Compare
According to the RFC8089 Section 2[1]:
> The generic syntax in [RFC3986] includes "path" and "authority"
components, for each of which only a subset is used in the definition
of the file URI scheme. The relevant subset of "path" is "path-
absolute"
'path-absolute' in RFC3986 is defined as beginning with a '/' character.
There's also a requirement in RFC3986 section 3.3 [2], that
> If a URI contains an authority component, then the path component
must either be empty or begin with a slash ("/") character.
For file:///c:/ URL the authority component is present but empty,
which implies 'localhost'. Thus the 'path' component must begin
with the '/' character.
For all intents and purposes 'file:///c:/' and 'file://localhost/c:/'
URLs are equivalent, so parsing them differently is a surprising behaviour.
Other popular languages like Java or JavaScript preserve the
leading slash character as well.
This effectively reverts commit [3].
[1] https://datatracker.ietf.org/doc/html/rfc8089#section-2
[2] https://datatracker.ietf.org/doc/html/rfc3986#section-3.3
[3] php@4505a61
Pchelolo
force-pushed
the
parse_url_windows_paths
branch
from
a18157a to
2badf46
Compare
|
I'm not sure about this. While the change is "technically correct", I suspect that it's going to break a significant amount of code, because "file:///" URIs will no longer "just work" on Windows. You now need to manually strip the leading slash. |
|
So better discuss this on the internals mailing list? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the RFC8089 Section 2[1]:
'path-absolute' in RFC3986 is defined as beginning with a '/' character.
There's also a requirement in RFC3986 section 3.3 [2], that
For file:///c:/ URL the authority component is present but empty,
which implies 'localhost'. Thus the 'path' component must begin
with the '/' character.
For all intents and purposes 'file:///c:/' and 'file://localhost/c:/'
URLs are equivalent, so parsing them differently is a surprising behaviour.
Other popular languages like Java or JavaScript preserve the
leading slash character as well.
This effectively reverts commit [3].
[1] https://datatracker.ietf.org/doc/html/rfc8089#section-2
[2] https://datatracker.ietf.org/doc/html/rfc3986#section-3.3
[3] 4505a61