Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverage was previously executed in nightly and honestly I don't think most people even knew it was there. It takes a bit longer than the other jobs but it's a useful metric and might as well be more visible.
Targeting PHP 8.0 not because it's super useful there but to avoid conflicts when merging other CI changes upstream.
TODO:
--enable-debug --disable-zts
job we probably might as well just combine the two, unless the job takes a significantly longer amount of time (I'll check after the jobs have finished)Ignore coverage for zpp and other undesired macrosWe can do that onmaster