fix tests on systemd enabled build #9537
Conversation
| assert(strpos($errorLogLines[4], 'NOTICE: using inherited socket')); | ||
|
|
||
| if (strpos($errorLogLines[2], 'systemd')) { | ||
| assert(strpos($errorLogLines[3], 'NOTICE: Reloading in progress')); |
There was a problem hiding this comment.
do you think using an offset would avoid repeating those ?
|
I'm actually just working on some changes in FPM tester which will address this issue. Also this test will be changed to look something like: https://github.com/bukka/php-src/blob/c03c38166f3d90f7e9a226d6b69d29fe10feee5d/sapi/fpm/tests/gh8885-stderr-fd-reload-usr2.phpt (not working yet so might be slightly different). Part of those changes will be skipping extra messages so it will be possible to use debug log (this is mainly so I can debug tests in the pipeline and get proper logging to see what's going on). It means it will also automatically skip this as well. It should be ready in the next few weeks and will go to 8.0 as I will need it for some other bug fixes. |
|
This should get fixed by #9588 |
|
Replaced by #9588 |
Adapt 2 new tests for systemd which add an additional line in log
NOTICE: systemd monitor interval set to...