Avoid creating indirect pointer in SplFixedArray __wakeup in 8.1+ #9706
+88
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A typed property of an object properties table is an indirect pointer (IS_IND) to a typed reference (IS_REF). With https://wiki.php.net/rfc/restrict_globals_usage, php 8.1 arrays are meant to stop containing IS_IND pointers, and php-src removed code to check for IS_IND pointers. `unserialize()` would also be affected. A more aggressive bug fix would be to also stop allowing references in unserialize entirely, though there's a tiny chance application behavior would depend on these references, so that fix wasn't backported.
|
SplFixedArray |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A typed property of an object properties table is an indirect pointer (IS_IND) to a typed reference (IS_REF).
With https://wiki.php.net/rfc/restrict_globals_usage, php 8.1 arrays are meant to stop containing IS_IND pointers,
and php-src removed code to check for IS_IND pointers.
unserialize()would also be affected.A more aggressive bug fix would be to also stop allowing references in unserialize entirely, though there's a tiny chance application behavior would depend on these references, so that fix wasn't backported.