Skip to content

Create a HaveCorrespondingUnit expression#397

Open
hgraca wants to merge 1 commit into
phparkitect:mainfrom
hgraca:feat/have_corresponding_unit
Open

Create a HaveCorrespondingUnit expression#397
hgraca wants to merge 1 commit into
phparkitect:mainfrom
hgraca:feat/have_corresponding_unit

Conversation

@hgraca

@hgraca hgraca commented Jul 26, 2023

Copy link
Copy Markdown
Contributor

This will allow us to ensure that certain classes always have a test, or that every test has a matching class and their namespaces are correct.

@hgraca hgraca force-pushed the feat/have_corresponding_unit branch from 85eef97 to 8ce42ab Compare August 5, 2023 13:25
@hgraca hgraca changed the title Create a HasCorrespondingUnit expression Aug 5, 2023
@hgraca hgraca force-pushed the feat/have_corresponding_unit branch 2 times, most recently from 11258dc to 0099166 Compare August 7, 2023 19:56
@hgraca hgraca marked this pull request as draft August 8, 2023 07:04
@hgraca

hgraca commented Aug 8, 2023

Copy link
Copy Markdown
Contributor Author

I converted this back to draft cozz I found some edge cases that are not working.
Once I fix that I will put the PR back to ready.

@hgraca hgraca marked this pull request as ready for review August 9, 2023 06:31
@hgraca

hgraca commented Aug 9, 2023

Copy link
Copy Markdown
Contributor Author

This is actually fine, my issue was at another place :)

@AlessandroMinoccheri

Copy link
Copy Markdown
Member

@hgraca Before approving, can you please add something to the readme file and fix pipelines :) ?

@hgraca hgraca force-pushed the feat/have_corresponding_unit branch from 0099166 to 95821e4 Compare September 5, 2023 08:21
This will allow us to ensure that certain classes always have a test,
or that every test has a matching class and their namespaces are correct.
@hgraca hgraca force-pushed the feat/have_corresponding_unit branch from 95821e4 to 66a9442 Compare September 5, 2023 08:22
@hgraca

hgraca commented Sep 5, 2023

Copy link
Copy Markdown
Contributor Author

@AlessandroMinoccheri done! The pipelines seem to not be running atm though...

@marmichalski

Copy link
Copy Markdown
Contributor

@AlessandroMinoccheri @micheleorselli is there anything left to be done here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants