-
Notifications
You must be signed in to change notification settings - Fork 6.1k
statistics: sync stats session time_zone with global value (#65821) #65935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-8.5
Are you sure you want to change the base?
statistics: sync stats session time_zone with global value (#65821) #65935
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@0xPoe This PR has conflicts, I have hold it. |
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@ti-chi-bot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #65821
What problem does this PR solve?
Issue Number: ref #65815
Problem Summary:
Root cause: internal stats sessions are created by
getSessionFactoryInternal(pkg/session/session.go) which setssessionVars.CommonGlobalLoaded = true, and internal SQL goes throughExecRestrictedSQL→ParseWithParams(pkg/session/session.go), which does not callloadCommonGlobalVariablesIfNeeded(). Together this means global sysvars liketime_zoneare never loaded for internal stats sessions, so they fall back to system TZ and skew time-based stats calculations (e.g. analyze_jobs duration).What changed and how does it work?
time_zoneinUpdateSCtxVarsForStats.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.