Make focused dropdowns searchable without first opening#3627
Merged
Conversation
KoolADE85
requested review from
T4rk1n,
camdecoster,
emilykl and
ndrezn
as code owners
|
Thank you for your contribution to Dash! 🎉 |
T4rk1n
approved these changes
Feb 25, 2026
Comment on lines
+507
to
+512
| const isSelected = | ||
| sanitizedValues.includes(firstVal); | ||
| const newSelection = isSelected | ||
| ? without([firstVal], sanitizedValues) | ||
| : append(firstVal, sanitizedValues); | ||
| updateSelection(newSelection); |
Contributor
There was a problem hiding this comment.
I think this would read better with a standard if else.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates dropdowns to be searchable without first opening:
Fixes #3572
Contributor Checklist
optionals
CHANGELOG.md