Skip to content

Fix misaligned slider marks with empty labels#3723

Merged
KoolADE85 merged 4 commits into
plotly:devfrom
terminalchai:fix-slider-mark-height
Apr 10, 2026
Merged

Fix misaligned slider marks with empty labels#3723
KoolADE85 merged 4 commits into
plotly:devfrom
terminalchai:fix-slider-mark-height

Conversation

@terminalchai

@terminalchai terminalchai commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add an explicit height: 12px to .dash-slider-mark so empty labels keep the same mark box height as labeled marks
  • add an integration regression test covering the empty-string marks case from #3715
  • add the corresponding unreleased changelog entry

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • add the slider mark height fix
    • add a regression test for empty mark labels
    • add the changelog entry
  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows
    • this GitHub #PR number updates the dash docs
    • here is the show and tell thread in Plotly Dash community

Fixes #3715

@AnnMarieW

Copy link
Copy Markdown
Collaborator

Thanks! Looks good.

@AnnMarieW

Copy link
Copy Markdown
Collaborator

Just needs a changelog entry

@terminalchai

Copy link
Copy Markdown
Contributor Author

Added the unreleased changelog entry and updated the PR checklist accordingly.

@KoolADE85 KoolADE85 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, it's looking good to me.

@KoolADE85 KoolADE85 merged commit 1fbfbac into plotly:dev Apr 10, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

5 participants