Skip to content

fix(confirmpopup): honor blockScroll and cleanup on destroy #19262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
moraisacr wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(confirmpopup): honor blockScroll and cleanup on destroy #19262

moraisacr wants to merge 1 commit into from

Conversation

@moraisacr
Copy link

@moraisacr moraisacr commented Jan 8, 2026

What's changed

  • ConfirmPopup now respects the blockScroll option, both via ConfirmationService and component input.
  • Ensures body scroll is properly restored when the popup is hidden or destroyed.

Why

blockScroll was previously ignored in ConfirmPopup, causing background scrolling and, in some cases, leftover overflow-hidden on <body> when the component was destroyed.

Tests

  • Manual verification

Fixes #17839
@vercel
Copy link

vercel bot commented Jan 8, 2026

@moraisacr is attempting to deploy a commit to the cetincakiroglu's projects Team on Vercel.

A member of the Team first needs to authorize it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@moraisacr