FIX: Select Placeholder and null/undefined Options overlap #19300
+12
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the 'p-inputwrapper-filled' class logic to apply when either the input is filled or a placeholder is present. This ensures correct styling when a placeholder is used.
Introduces a computed property to detect if any option value is null or undefined in the Select component. Updates styling logic to consider this state for the 'p-inputwrapper-filled' class.
|
@chdanielmueller is attempting to deploy a commit to the cetincakiroglu's projects Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #19299
Before
After
Summary
This pull request introduces an enhancement to the
Selectcomponent to improve how the input wrapper's filled state is determined. The main change is the addition of logic to check fornullorundefinedoptions, ensuring that the component visually reflects its state more accurately.Enhancement to input wrapper filled state:
hasNullOrUndefinedOptioninselect.tsthat checks if any option value isnullorundefined.p-inputwrapper-filledclass logic inselectstyle.tsto also consider the presence of a placeholder or anynull/undefinedoptions, making the filled state more robust.